Skip to content

Conversation

@DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Oct 2, 2025

Just a simple missing impl. I don't think this is worth making a patch for.

@nicoburns
Copy link
Contributor

nicoburns commented Oct 6, 2025

I think we ought to have a generic From<T> for ImageBrush<T>. That's probably inference-level breaking.

Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@sagudev
Copy link
Contributor

sagudev commented Oct 10, 2025

Just a simple missing impl. I don't think this is worth making a patch for.

I need patch for #148 anyway, so I will wait for this to land then prepare patch PR.

@DJMcNab
Copy link
Member Author

DJMcNab commented Oct 15, 2025

I think we ought to have a generic From<T> for ImageBrush<T>. That's probably inference-level breaking.

To clarify, we talked about this in office hours, and the reason I haven't added this is that the generic parameter is currently more of an implementation detail (because the two forms have a lot of shared methods), than something we're formally supporting. This is all up-in-the-air as we work out Vello API/Anyrender stuff.

@DJMcNab DJMcNab added this pull request to the merge queue Oct 15, 2025
Merged via the queue into linebender:main with commit 639684a Oct 15, 2025
15 checks passed
@DJMcNab DJMcNab deleted the convenience branch October 15, 2025 07:51
@sagudev
Copy link
Contributor

sagudev commented Nov 5, 2025

Just a simple missing impl. I don't think this is worth making a patch for.

I need patch for #148 anyway, so I will wait for this to land then prepare patch PR.

Given that breaking stuff have landed on main in the mean time, should we backport these? I mostly need #148 for linebender/vello#1268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants