Set rust-version for workspace members#842
Merged
DJMcNab merged 1 commit intolinebender:mainfrom Nov 8, 2024
Merged
Conversation
Member
|
Welcome @sorairolake! This PR has arrived at an interesting time for the project, as we're going through a relicensing. To be able to accept this contribution, we're going to need you to agree to that - see #838 One other note, the badge in the README lists the MSRV as 1.67.1. I'd probably set the MSRV to that to start with. Thank you |
Contributor
Author
Contributor
Author
|
@DJMcNab The MSRV of |
Member
|
When we move to Linebender CI (see linebender/rfcs#5), we will probably want to have a unified MSRV. But since this isn't being checked, just specifying the actual reality is fine. Thank you! |
DJMcNab
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edition of all crates in this repository are Rust 2021 (requires Rust 1.56.0 or later). So we can set the
rust-versionfield for theCargo.tomlfile. This makes it easier to check the crate's MSRV.I didn't feel the need to set this field for crates which aren't published on crates.io, so I didn't set the field for
codegenandexplorer-thumbnailercrates.