Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support no_std #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support no_std #39

wants to merge 1 commit into from

Conversation

waywardmonkeys
Copy link
Collaborator

No description provided.

@waywardmonkeys
Copy link
Collaborator Author

For this to work, we'd need a semver bump for core:error::Error, but that's coming when we use color.

I'm also not sure how generally useful this feature would be, so feedback is welcome.

@waywardmonkeys waywardmonkeys force-pushed the support-no_std branch 2 times, most recently from 0688cd2 to 5efb018 Compare December 27, 2024 17:33
tomcur
tomcur reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@tomcur tomcur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this is important for someone. The only real downside is the big jump in MSRV and the semver bump, so perhaps it should just be delayed until color is ready to go in as well, allowing one more patch release just prior.

@waywardmonkeys
Copy link
Collaborator Author

Yeah, I am inclined to do a 0.15.3 with roughly the current state of main and then 0.16 with color and no_std.

@waywardmonkeys waywardmonkeys added this to the 0.16 milestone Dec 28, 2024
@waywardmonkeys
Support no_std
afb19df 
This increases the MSRV to 1.81 for `core::error`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomcur tomcur tomcur left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @tomcur