Experiments on frame pacing in Android #674
Draft
+1,175
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
force-pushed
the
android-pacing
branch
from
ddf272c
to
bbb7172
Compare
| @@ -701,6 +770,8 @@ fn run( | |||
| let debug = vello::DebugLayers::none(); | |||
|
|
|||
| let mut app = VelloApp { | |||
| present_id: 0, | |||
| google_display_timing_ext_devices: vec![None; renderers.len()], | |||
There was a problem hiding this comment.
Should keep the same order as the declaration and put them in the opposite order under renderers ?
vello_pacing/src/lib.rs
Outdated
| std::thread::spawn(|| self.run()); | ||
| } | ||
|
|
||
| /// Run a rendering task until presentation. Useful on macOS for resizing. |
There was a problem hiding this comment.
Mads has been doing new work on macOS with respect to resizing!
sdl2 doesn't build (trivially) on Android, so just prefer to not make it build by default We emulate an optional package using cargo features.
Also start sketching out the frame pacing library
DJMcNab
force-pushed
the
android-pacing
branch
from
daf0817
to
786f41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR has two things:
with_winitof hal: cargo feature to allow usingVK_GOOGLE_display_timingunsafely gfx-rs/wgpu#6149See #gpu > Latency Investigation