Update Peniko #769
Update Peniko #769
Conversation
|
This builds on linebender/peniko#85 |
vello_encoding/src/ramp_cache.rs
Outdated
| entry.1 = self.epoch; | ||
| entry.0 | ||
| } else if self.map.len() < RETAINED_COUNT { | ||
| let id = (self.data.len() / N_SAMPLES) as u32; | ||
| self.data.extend(make_ramp(stops)); | ||
| self.map.insert(stops.into(), (id, self.epoch)); | ||
| self.map | ||
| .insert(CacheKey(ColorStops(stops.into())), (id, self.epoch)); |
There was a problem hiding this comment.
I'm not thrilled about this change to ColorStops(stops.into()) rather than perhaps going and doing some better impls for From or something in Peniko.
There was a problem hiding this comment.
linebender/peniko#86 allows for CacheKey(ColorStops::from(stops)) / CacheKey(stops.into()).
There was a problem hiding this comment.
But really this copying of the color stops just to serve as key seems suboptimal since what we could probably do this with the Range<usize> that we have available in the resolver code. But that's not for this PR.
There was a problem hiding this comment.
We can't currently do that ... I just tried, but we can't rely on data in the Resources::color_stops being uniqued, so we can't use the range of it as a key.
|
@DJMcNab This is to help make sure that all is well before we go and publish the new version of Peniko so this doesn't have to land by itself yet ... |
vello_encoding/src/ramp_cache.rs
Outdated
| @@ -35,13 +36,14 @@ impl RampCache { | |||
| } | |||
|
|
|||
| pub(crate) fn add(&mut self, stops: &[ColorStop]) -> u32 { | |||
| if let Some(entry) = self.map.get_mut(stops) { | |||
| if let Some(entry) = self.map.get_mut(&CacheKey(ColorStops(stops.into()))) { | |||
There was a problem hiding this comment.
This is not ideal, as it allocates "unnecessarily". It really complicates the traits in the Color crate to make this work nicely, I think.
waywardmonkeys
force-pushed
the
update-peniko
branch
2 times, most recently
from
31e7634 to
4a3f672
Compare
waywardmonkeys
force-pushed
the
update-peniko
branch
from
4a3f672 to
e53d2d9
Compare
No description provided.