Skip to content

Comments

Add initial code from Vello.#1

Merged
nuzzles merged 34 commits intomainfrom
initial-seed
Mar 11, 2024
Merged

Add initial code from Vello.#1
nuzzles merged 34 commits intomainfrom
initial-seed

Conversation

@nuzzles
Copy link
Member

@nuzzles nuzzles commented Mar 9, 2024

This PR initializes the repo to a basic state.

@nuzzles nuzzles changed the title Initial seed repo Draft: Initial seed repo Mar 9, 2024
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had time to only quickly skim a few files, but I already have a few comments inline.

The unifying idea of my complaints is that I think we should stick more closely to established Linebender culture. Not to say that these things are unchangeable forever, but at the very least this initial seed is the wrong place to start changing such things.

Co-authored-by: Kaur Kuut <strom@nevermore.ee>
@nuzzles
Copy link
Member Author

nuzzles commented Mar 9, 2024

I had time to only quickly skim a few files, but I already have a few comments inline.

The unifying idea of my complaints is that I think we should stick more closely to established Linebender culture. Not to say that these things are unchangeable forever, but at the very least this initial seed is the wrong place to start changing such things.

They were good comments, thanks for the initial review.

@nuzzles nuzzles requested a review from xStrom March 9, 2024 15:01
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's another pass. Might have missed something, because looks like the fork wasn't based on the freshest main of the Vello repo. Although I guess we don't necessarily need all of that, like vello#435?

nuzzles and others added 9 commits March 9, 2024 16:00
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've reached a state where this can be merged. 🎉

Before merging, I'll note two things:

  • The PR title should be changed (I'll just do it myself in a second)
  • Use the Squash Merge option to do the merge, as that is the Linebender way

Thanks for putting in the effort to get this landed!

@xStrom xStrom changed the title Draft: Initial seed repo Add initial code from Vello. Mar 11, 2024
@nuzzles nuzzles merged commit 3d1d99d into main Mar 11, 2024
@nuzzles nuzzles deleted the initial-seed branch March 11, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants