Conversation
xStrom
left a comment
There was a problem hiding this comment.
I had time to only quickly skim a few files, but I already have a few comments inline.
The unifying idea of my complaints is that I think we should stick more closely to established Linebender culture. Not to say that these things are unchangeable forever, but at the very least this initial seed is the wrong place to start changing such things.
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
They were good comments, thanks for the initial review. |
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
xStrom
left a comment
There was a problem hiding this comment.
I think we've reached a state where this can be merged. 🎉
Before merging, I'll note two things:
- The PR title should be changed (I'll just do it myself in a second)
- Use the Squash Merge option to do the merge, as that is the Linebender way
Thanks for putting in the effort to get this landed!
This PR initializes the repo to a basic state.