Repository navigation
Avoid origin assumptions in box model API. - #1813
Merged
Merged
Conversation
xStrom
added
masonry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout accessor methods
content_box_size,border_box_size, andpaint_box_sizeare encouraging direct usage without considering the origin of these boxes, which leads to subtle bugs.This PR removes those context methods, plus
WidgetState::border_box_size.The size can still be accessed through e.g.
border_box().size(), while making correct usage in general more likely. For exampleborder_box().contains(pos)instead ofborder_box_size().to_rect().contains(pos), orborder_box().center()instead ofborder_box_size() / 2..A few widgets got updated with the more robust approach of using e.g.
.center(), but generally e.g.content_box_size()just got replaced withcontent_box().size(). Thus, this PR is focused on changing the API in a way that is more conducive to correct use, but analyzing and fixing all existing widget code is out of scope for this PR.This PR also adds a few more box model tests, to make sure that these APIs actually work as advertised.