Repository navigation
Merge MasonryState into MainState - #1846
Closed
HigherOrderLogic wants to merge 1 commit into
Closed
HigherOrderLogic wants to merge 1 commit into
HigherOrderLogic wants to merge 1 commit into
Conversation
Collaborator
|
Looks good on first glance. I'm not super clear what |
Contributor
Author
It's just a private helper to not repeating taking the app driver out of the |
Collaborator
|
Sorry for the radio silence, I've been sick.
I see that it's a way to get around the lifetime issues you get from merging the two types. If we have to add this kind of hack, I'd rather we keep the two types separate for now and do a deeper refactor later. |
Contributor
Author
|
I'll close the PR then. |
Collaborator
|
Yeah, sorry if that's unsatisfying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More progress on #1836.
Would love to get some feedback on the use of the optional
AppDriver. I cant think of any better way to execute it.