Repository navigation
fix(masonry): use different selection color for unfocused Prose - #1856
Merged
PoignardAzur merged 1 commit intoOct 29, 2026
Merged
PoignardAzur merged 1 commit into
PoignardAzur merged 1 commit into
Conversation
This was discovered while checking out new tests for linebender#1341 It looks to be a miss in the current Prose code. The code (both in test and in implementation) mostly follows what already exists in TextInput. Support for CaretColor property is added as a logical addition to SelectionColor. LLM was used as a consultant for this change.
PoignardAzur
approved these changes
Oct 29, 2026
Comment on lines
+154
to
+161
| // FIXME - Find more elegant way to propagate property to child. | ||
| if property_type == TypeId::of::<CaretColor>() { | ||
| ctx.mutate_self_later(|mut input| { | ||
| let mut input = input.downcast::<Self>(); | ||
| let color = *input.get_prop::<CaretColor>(); | ||
| let mut text_area = Self::text_mut(&mut input); | ||
| text_area.insert_prop(color); | ||
| }); |
Collaborator
There was a problem hiding this comment.
What is this? That is such incredibly ugly code, I cannot belie- oh, right, we already do this everywhere else.
Jokes aside, we need property inheritance so badly. =(
Contributor
Author
There was a problem hiding this comment.
those FIXMEs looked suspicious to me as well, I suppose #1342 is the main ticket on this topic, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discovered while checking out new tests for #1341
It looks to be a miss in the current Prose code. The code (both
in test and in implementation) mostly follows what already exists
in TextInput. Support for CaretColor property is added as a logical
addition to SelectionColor.
LLM was used as a consultant for this change.