De-traitify text module #515
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Aug 15, 2024
| @@ -675,27 +616,43 @@ impl<Str: Deref<Target = str> + TextStorage> Selectable for Str { | |||
| } | |||
| } | |||
|
|
|||
| /// A cursor type that implements `EditableTextCursor` for string types | |||
| /// A cursor type with helper methods for working with strings. | |||
| #[derive(Debug)] | |||
| pub struct StringCursor<'a> { | |||
There was a problem hiding this comment.
Why is this still pub? It has no public API except for construction.
Comment on lines
+653
to
+654
| /// Move cursor to previous codepoint boundary, if it exists. | ||
| /// Returns previous codepoint as usize offset. |
There was a problem hiding this comment.
Suggested change
| /// Move cursor to previous codepoint boundary, if it exists. | |
| /// Returns previous codepoint as usize offset. | |
| /// Move cursor to previous codepoint boundary, if it exists. | |
| /// Returns previous codepoint as usize offset, or `None` if this cursor was already at the first boundary. |
Comment on lines
228
to
235
| // TODO: This is *definitely* empty | ||
| #[cfg(FALSE)] | ||
| if !self.text_layout.text().links().is_empty() { | ||
| tracing::warn!("Links present in text, but not yet integrated"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| // TODO: This is *definitely* empty | |
| #[cfg(FALSE)] | |
| if !self.text_layout.text().links().is_empty() { | |
| tracing::warn!("Links present in text, but not yet integrated"); | |
| } | |
| // When we add links to `Prose`, they will probably need to be handled here. |
Comment on lines
+208
to
211
| #[cfg(FALSE)] | ||
| if !self.text_layout.text().links().is_empty() { | ||
| tracing::warn!("Links present in text, but not yet integrated"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| #[cfg(FALSE)] | |
| if !self.text_layout.text().links().is_empty() { | |
| tracing::warn!("Links present in text, but not yet integrated"); | |
| } |
Label will never support links
PoignardAzur
force-pushed
the
refactor_text
branch
from
722c639
to
d35bd2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.