-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refactor installation instructions #2060
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
I'm reviewing thru reading docs on the deployment preview, will write down here a notes:
I'm continuing reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM. THanks for update, that were a lot of duplications indeed.
@timofei-iatsenko thanks for the quick review. Just pushed the updated version. |
I also think it would be nice to add Rspack and Webpack to the Build Tools section in the new article. |
Co-authored-by: Vojtech Novak <[email protected]>
@vonovak thanks for the review! I have updated everything according to your suggestions. |
Description
This pull request aims to reduce user confusion in the Getting Started section of the website and put all installation and basic setup instructions in one place. This also makes the Getting Started section more framework/toolkit-agnostic.
A quick overview of the changes:
From the reader's perspective, the React Project and Vite Project were confusing since it's not clear why it was differentiated into React and Vite and it could lead to wrong assumptions or questioning all of this even more.
In general, it should reduce code duplication and make reading easier for the developer.
🖼️ Deployment Preview
Types of changes
Checklist