Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
char
is a 16-bit UTF-16 character, it doesn't support characters outside the BMP encoding range and need to be combined as surrogate pairs.Rune
is essentially a 32-bit UTF-32 character, and can support all Unicode characters, including emojis. It's wonderful.This PR adds:
ValueStringBuilder.Append(Rune)
ValueStringBuilder.AppendJoin(Rune, IEnumerable<string?>)
ValueStringBuilder.AppendJoin<T>(Rune, IEnumerable<T>)
This PR also optimises
AppendLine(scoped ReadOnlySpan<char>)
by avoiding an unnecessary string allocation. It also removes an unnecessary null check inAppendJoinInternalString<T>(ReadOnlySpan<char>, IEnumerable<T>)
.