Skip to content

Commit

Permalink
minor
Browse files Browse the repository at this point in the history
  • Loading branch information
snalli committed Jan 15, 2025
1 parent 5ee3e0d commit 5f45409
Showing 1 changed file with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,8 @@ List<ChunkInfo> getChunksToStitch(CompleteMultipartUpload completeMultipartUploa
* @throws RestServiceException
*/
@NotNull int getPartNumber(@NotNull Part part) throws RestServiceException {

Check failure on line 459 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / int-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull int getPartNumber(@NotNull Part part) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 459 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / int-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull int getPartNumber(@NotNull Part part) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 459 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / server-int-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull int getPartNumber(@NotNull Part part) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 459 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / server-int-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull int getPartNumber(@NotNull Part part) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 459 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / unit-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull int getPartNumber(@NotNull Part part) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 459 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / unit-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull int getPartNumber(@NotNull Part part) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 459 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / store-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull int getPartNumber(@NotNull Part part) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 459 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / store-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull int getPartNumber(@NotNull Part part) throws RestServiceException { ^ symbol: class NotNull
int partNumber;
try {
partNumber = part.getPartNumber();
return part.getPartNumber();
} catch (NumberFormatException e) {
// cannot use getPartNumber() here as it would cause another exception
String error = String.format(S3Constants.ERR_INVALID_PART_NUMBER, part);
Expand All @@ -468,7 +467,6 @@ List<ChunkInfo> getChunksToStitch(CompleteMultipartUpload completeMultipartUploa
// any other exception is invalid
throw new RestServiceException(S3Constants.ERR_INVALID_MULTIPART_UPLOAD, RestServiceErrorCode.BadRequest);
}
return partNumber;
}

/**
Expand All @@ -478,12 +476,13 @@ List<ChunkInfo> getChunksToStitch(CompleteMultipartUpload completeMultipartUploa
* @throws RestServiceException
*/
@NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException {

Check failure on line 478 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / int-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 478 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / int-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 478 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / server-int-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 478 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / server-int-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 478 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / unit-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 478 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / unit-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 478 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / store-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException { ^ symbol: class NotNull

Check failure on line 478 in ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java

View workflow job for this annotation

GitHub Actions / store-test

[Task :ambry-frontend:compileJava FAILED] cannot find symbol @NotNull List<Part> getParts(@NotNull CompleteMultipartUpload request) throws RestServiceException { ^ symbol: class NotNull
if (request.getPart() == null) {
Part[] part = request.getPart();
if (part == null) {
throw new RestServiceException(S3Constants.ERR_EMPTY_REQUEST_BODY, RestServiceErrorCode.BadRequest);
}
// Arrays.asList() can return an empty list, but only if it is called with no arguments.
// Therefore, the list below will always have at least one element as we are passing an argument.
List<Part> parts = Arrays.asList(request.getPart());
List<Part> parts = Arrays.asList(part);
if (parts.size() > S3Constants.MAX_LIST_SIZE) {
throw new RestServiceException(S3Constants.ERR_PART_LIST_TOO_LONG, RestServiceErrorCode.BadRequest);
}
Expand Down

0 comments on commit 5f45409

Please sign in to comment.