Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bug in the DiskFailureHandler #2656

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

justinlin-linkedin
Copy link
Collaborator

Summary

This pr fixes some errors in the disk failure handler logic

  1. If disk failure handler failed, we should remove the newly failed disk from the list so next time we can reprocess it.
  2. Remove the termination logic
  3. Add some checks if the replicas is empty.

Test

Added some new unit test cases.

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (fdc4ec2) 32.40% compared to head (54715e9) 72.53%.

Files Patch % Lines
...in/java/com/github/ambry/store/StorageManager.java 27.27% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2656       +/-   ##
=============================================
+ Coverage     32.40%   72.53%   +40.12%     
- Complexity     4460    11508     +7048     
=============================================
  Files           806      806               
  Lines         65491    65485        -6     
  Branches       7994     7996        +2     
=============================================
+ Hits          21225    47502    +26277     
+ Misses        42031    15374    -26657     
- Partials       2235     2609      +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinlin-linkedin justinlin-linkedin merged commit 9870584 into linkedin:master Nov 28, 2023
5 checks passed
@justinlin-linkedin justinlin-linkedin deleted the justin/fix branch November 28, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants