[HelixTask] Reduce memory footprint to minimize GC pauses #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2657 +/- ##
============================================
+ Coverage 32.40% 33.36% +0.95%
- Complexity 4460 5138 +678
============================================
Files 806 809 +3
Lines 65491 65515 +24
Branches 7994 7994
============================================
+ Hits 21225 21857 +632
+ Misses 42031 41964 -67
+ Partials 2235 1694 -541 ☔ View full report in Codecov by Sentry. |
justinlin-linkedin
approved these changes
Nov 28, 2023
ambry-clustermap/src/main/java/com/github/ambry/clustermap/MySqlClusterAggregator.java
Outdated
Show resolved
Hide resolved
ambry-clustermap/src/main/java/com/github/ambry/clustermap/MySqlClusterAggregator.java
Show resolved
Hide resolved
|
Could you please change the title to be more aligned with your change? |
snalli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontends are timing out connecting to servers because servers are busy with GC. The GC pause is 3-second long because JVM is busy releasing memory consumed by StatsAggregator. The aggregator fetches results for all accounts, containers and partitions to store it in a giant map, which consumes close to 10GB of heap.
This patch fixes this issue by not buffering those stats. Instead it fetches each stat and immediately processes it without saving it for further use.