Include leaderless replicas for GET replication requests #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2661 +/- ##
============================================
- Coverage 72.63% 72.59% -0.05%
+ Complexity 11537 11529 -8
============================================
Files 809 809
Lines 65545 65551 +6
Branches 7997 7998 +1
============================================
- Hits 47611 47586 -25
- Misses 15334 15355 +21
- Partials 2600 2610 +10 ☔ View full report in Codecov by Sentry. |
justinlin-linkedin
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During leader-based replication, we only include leaders for fetching actual data. For non-leaders, we wait for 2 minutes hoping that the data would be fetched via intra-colo replication. This causes issue of very slow replication if leader is missing. To avoid that, we are fetching data for replicas without any leaders in this PR.