Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable S3BatchDelete #2965

Merged
merged 27 commits into from
Jan 31, 2025
Merged

Enable S3BatchDelete #2965

merged 27 commits into from
Jan 31, 2025

Conversation

snalli
Copy link
Contributor

@snalli snalli commented Dec 13, 2024 •
edited by allenaverbukh
Loading

This PR implements S3BatchDelete API. Each requests takes multiple keys to delete and a returns a batch response including the status of delete - success or fail - for each key.

justinlin-linkedin
justinlin-linkedin requested changes Jan 15, 2025
View reviewed changes
ambry-protocol/src/main/java/com/github/ambry/protocol/BatchDeletePartitionRequestInfo.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/BatchDeleteRequest.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/BatchDeleteRequest.java Outdated Show resolved Hide resolved
ambry-router/src/main/java/com/github/ambry/router/NonBlockingRouter.java Outdated Show resolved Hide resolved
ambry-server/src/main/java/com/github/ambry/server/AmbryRequests.java Outdated Show resolved Hide resolved
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3BatchDeleteHandler.java Outdated Show resolved Hide resolved
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3BatchDeleteHandler.java Outdated Show resolved Hide resolved
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3BatchDeleteHandler.java Outdated Show resolved Hide resolved
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3BatchDeleteHandler.java Outdated Show resolved Hide resolved
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3BatchDeleteHandler.java Outdated Show resolved Hide resolved
@justinlin-linkedin
Copy link
Collaborator

Looking mostly good. could you please

  1. Update the title of this PR.
  2. Add more details to the description of this PR.

@allenaverbukh allenaverbukh changed the title [WIP] s3BatchDelete Enabled S3BatchDelete API for Flink team Jan 30, 2025
@snalli
Copy link
Contributor Author

snalli commented Jan 30, 2025 •
edited
Loading

@allenaverbukh
PR Title: Enable S3BatchDelete
Description :
This PR implements S3BatchDelete API. Each requests takes multiple keys to delete and a returns a batch response including the status of delete - success or fail - for each key.

@snalli snalli removed the request for review from allenaverbukh January 30, 2025 21:42
@allenaverbukh allenaverbukh changed the title Enabled S3BatchDelete API for Flink team Enable S3BatchDelete Jan 30, 2025
snalli
snalli commented Jan 30, 2025
View reviewed changes
Copy link
Contributor Author

@snalli snalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allenaverbukh allenaverbukh merged commit 2ed0456 into master Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlin-linkedin justinlin-linkedin justinlin-linkedin approved these changes

@allenaverbukh allenaverbukh allenaverbukh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snalli @justinlin-linkedin @allenaverbukh