[S3] Validate parts in multi-part upload #2981
Merged
+174
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snalli
reviewed
Jan 11, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 11, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 11, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 11, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 11, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 11, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 12, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Show resolved
Hide resolved
snalli
reviewed
Jan 14, 2025
ambry-frontend/src/test/java/com/github/ambry/frontend/S3MultipartUploadTest.java
Show resolved
Hide resolved
|
|
||
| Set<Integer> partNumbers = new HashSet<>(); | ||
| Set<String> etags = new HashSet<>(); | ||
|
|
| for (Part part : parts) { | ||
| int partNumber = part.getPartNumber(); | ||
| String etag = part.geteTag(); | ||
|
|
| "Invalid part number: " + part.getPartNumber() + ". Part number must be an integer between {} and {}.", | ||
| MIN_PART_NUM, MAX_PART_NUM); | ||
| } | ||
|
|
| if (!partNumbers.add(partNumber)) { | ||
| return "Duplicate part number found: " + partNumber; | ||
| } | ||
|
|
|
Nit : change title to Make sure this is the title when merging else github will use the original title |
alyssaxu333
changed the title
alyssaxu333
force-pushed
the
addPartCheckForCompleteRequest
branch
from
d16b951 to
7c1ebb6
Compare
alyssaxu333
force-pushed
the
addPartCheckForCompleteRequest
branch
from
85c1b2a to
3b9c81e
Compare
snalli
reviewed
Jan 15, 2025
ambry-frontend/src/main/java/com/github/ambry/frontend/s3/S3MultipartCompleteUploadHandler.java
Outdated
Show resolved
Hide resolved
snalli
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no check for the invalid part number and duplicate etags. Add checks for part number that is negative, decimal or larger than 10000, throw Bad Request Error. Add checks for duplicate eTags in the request to avoid time out.