Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put blob perf test #2994

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

put blob perf test #2994

wants to merge 8 commits into from

Conversation

manbearpig1996
Copy link
Contributor

@manbearpig1996 manbearpig1996 commented Jan 27, 2025 •
edited
Loading

  1. Refactor existing serverPerformanceTest to be more modular.
  2. ServerPerformanceTest contains 2 threads one for producer one for consumer
  3. Interface for LoadProducerConsumer created.
  4. Implemented this interface in GetLoadProducerConsumer and move get testing logic in this class.
  5. Implemented this interface in PUTLoadProducerConsumer which will select one partition per disk in the given host and send PUT requests to these replicas.

@manbearpig1996 manbearpig1996 marked this pull request as ready for review February 6, 2025 09:13
mudit-saxena
mudit-saxena reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@mudit-saxena mudit-saxena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a README.MD file for the performance test. Explaining

  • How to run test i.e required configs, input
  • Monitor the progress through metrics/logs
  • Final output of perf test

@manbearpig1996
Copy link
Contributor Author

Can you add a README.MD file for the performance test. Explaining

  • How to run test i.e required configs, input
  • Monitor the progress through metrics/logs
  • Final output of perf test

@mudit-saxena Added these. For the detailed metric we need to monitor the metrics from the target node. These will be visible in metrics dashboards.

mudit-saxena
mudit-saxena approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@mudit-saxena mudit-saxena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudit-saxena mudit-saxena mudit-saxena approved these changes

@justinlin-linkedin justinlin-linkedin Awaiting requested review from justinlin-linkedin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manbearpig1996 @mudit-saxena