-
Notifications
You must be signed in to change notification settings - Fork 558
[WIP]: Add OpenTelemetry metrics support for XDS Client #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aadityaraj7769
wants to merge
8
commits into
linkedin:master
Choose a base branch
from
aadityaraj7769:adiraj/xdsclient-otel-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7a43c50
added the otel changes
54a8401
Added more logic for the XdsClient Otel metrics
0df69f4
Use NoOpXdsClientOtelMetricsProvider as default to eliminate null han…
ea5faa4
Update comments in XdsClientOtelMetricsProvider.java
aadityaraj7769 e9155b3
Added tests for XdsClientOtelMetricsProvider
5cd8559
Resolved PR comments
f710f7e
Resolved PR comments
aadityaraj7769 4effe1e
revert d2jmxconstant changes.
aadityaraj7769 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
d2/src/main/java/com/linkedin/d2/jmx/NoOpXdsClientOtelMetricsProvider.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| package com.linkedin.d2.jmx; | ||
|
|
||
| /** | ||
| * No-Op implementation of {@link XdsClientOtelMetricsProvider}. | ||
| * Used when OpenTelemetry metrics are disabled. | ||
| */ | ||
| public class NoOpXdsClientOtelMetricsProvider implements XdsClientOtelMetricsProvider { | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordConnectionLost(String clientName) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordConnectionClosed(String clientName) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordReconnection(String clientName) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordRequestSent(String clientName) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordResponseReceived(String clientName) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordInitialResourceVersionSent(String clientName, int count) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordResourceNotFound(String clientName) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordResourceInvalid(String clientName) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void recordServerLatency(String clientName, long latencyMs) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void updateConnectionState(String clientName, boolean isConnected) { | ||
| // No-op | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void updateActiveInitialWaitTime(String clientName, long waitTimeMs) { | ||
| // No-op | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docstring
{@inheritDoc}for all of these methodsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.