Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for Maven with Gradle Module Metadata #569

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DPUkyle
Copy link
Member

@DPUkyle DPUkyle commented Mar 23, 2021

Also forces pegasus artifacts to be reproducible

--

Does not strictly depend on #568, but should be rebased after it is merged.

 - This change does not require the consumer to use Gradle 6.1
 - Forthcoming opt-in features to improve metadata publishing will require Gradle 6.1 (linkedin#565)
 - Fixes to linkedin#561 require Gradle 5.4 or higher
 - Consumers of the pegasus plugin must use Gradle 5.4+
   - `@ReplacedBy` annotation requires Gradle 5.4+
   - `o.g.w.InputChanges` API requires Gradle 5.4+
@DPUkyle DPUkyle marked this pull request as draft March 23, 2021 06:00
@DPUkyle
Copy link
Member Author

DPUkyle commented Mar 23, 2021

Test failures might be due to JDK version discrepancies; travis uses 1.8.0_151, while I have 1.8.0_181 locally. I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant