Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document Linkerd and Gateway HTTPRoute API groups #1667

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented Aug 22, 2023

As of Linkerd 2.14, we now support HTTPRoutes with both the policy.linkerd.io and gateway.networking.k8s.io API groups. This branch adds documentation discussing the differences between these two API groups, and notes in the docs stating that both are supported.

As of Linkerd 2.14, we now support HTTPRoutes with both the
`policy.linkerd.io` and `gateway.networking.k8s.io` API groups. This
branch adds documentation discussing the differences between these two
API groups, and notes in the docs stating that both are supported.
@hawkw hawkw requested review from kflynn, alpeb, wmorgan and adleong and removed request for alpeb August 22, 2023 00:29
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. 🙂 Do you think it's worth calling out the need to fully qualify one or the other HTTPRoute when using kubectl?

Approving irrespective of the above. 🙂

@alpeb
Copy link
Member

alpeb commented Aug 22, 2023

This looks great. 🙂 Do you think it's worth calling out the need to fully qualify one or the other HTTPRoute when using kubectl?

This is a great point. It appears httproutes.policy.linkerd.io now becomes the default, and I remember someone was confused because the httproutes.gateway.networking.k8s.io resources weren't showing up.

@hawkw
Copy link
Contributor Author

hawkw commented Aug 22, 2023

This looks great. 🙂 Do you think it's worth calling out the need to fully qualify one or the other HTTPRoute when using kubectl?

This is a great point. It appears httproutes.policy.linkerd.io now becomes the default, and I remember someone was confused because the httproutes.gateway.networking.k8s.io resources weren't showing up.

i'll add something about that, good call.

@hawkw hawkw merged commit e5e16cc into main Aug 22, 2023
7 checks passed
@hawkw hawkw deleted the eliza/upstream-routes branch August 22, 2023 17:44
sourishkrout pushed a commit to stateful/linkerd-website that referenced this pull request Aug 23, 2023
As of Linkerd 2.14, we now support HTTPRoutes with both the
`policy.linkerd.io` and `gateway.networking.k8s.io` API groups. This
branch adds documentation discussing the differences between these two
API groups, and notes in the docs stating that both are supported.
sourishkrout pushed a commit to stateful/linkerd-website that referenced this pull request Aug 23, 2023
As of Linkerd 2.14, we now support HTTPRoutes with both the
`policy.linkerd.io` and `gateway.networking.k8s.io` API groups. This
branch adds documentation discussing the differences between these two
API groups, and notes in the docs stating that both are supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants