Adds helm chart to app version matrix #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logicminds
force-pushed
the
version_matrix
branch
2 times, most recently
from
1f21c46
to
3068a3f
Compare
logicminds
force-pushed
the
version_matrix
branch
from
3068a3f
to
a220a28
Compare
|
@logicminds Hmmm, the Python script actually doesn't seem to be present in this PR? 🙂 |
logicminds
force-pushed
the
version_matrix
branch
from
a220a28
to
8035e93
Compare
ahh. The bin directory was ignored which prevented the script from being added. I have fixed this but wondering why bin was ignored in the first place. |
logicminds
force-pushed
the
version_matrix
branch
from
8035e93
to
7e6cefb
Compare
|
Wow, that looks more painful than I thought. Thanks!! If you can fix the linter errors, I'll see about getting this landed -- appreciate it! |
logicminds
force-pushed
the
version_matrix
branch
from
7e6cefb
to
658036e
Compare
|
@kflynn please run the checks as I am unable to do so |
* Previously, there was not an easy way to correlate the app version
to a helm chart version. Many people ask this question in public
slack channel or must get data themselves. This adds a script
to produce the desired matrix data as a table, json, or yaml output
to help folks who are upgrading.
Signed-off-by: Corey Osman <[email protected]>
* Previously the bin directory was being ignored despite this being
a logical place to contain scripts. It has been re-enabled
and the python script was added as a result.
* Update script to handle edge releases better
Signed-off-by: Corey Osman <[email protected]>
Signed-off-by: Corey Osman <[email protected]>
Signed-off-by: Corey Osman <[email protected]>
logicminds
force-pushed
the
version_matrix
branch
from
658036e
to
d0a7e2d
Compare
kflynn
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Let's get this landed. 🙂 Many thanks for sticking with this, @logicminds! I'll likely do some tweaks to the way this fits into the build process, but having this as a base will be a big win.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was not an easy way to correlate the app version to a helm chart version. Many people ask this question in public slack channel or must get data themselves. This adds a script to produce the desired matrix data as a table, json, or yaml output to help folks who are upgrading. Without this matrix the versions are very confusing. A python script is provided to generate the necessary data.
This also adds a new make target to produce the content
build-release-matrix. I prepended the target call to thebuild-linkerd.iotarget so that upon creation the data would be generated.