Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a "common errors" page. #1752

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Have a "common errors" page. #1752

merged 5 commits into from
Apr 4, 2024

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Mar 12, 2024

This is obviously not a complete list -- it's meant to be a start that we add to.

Signed-off-by: Flynn [email protected]

@kflynn kflynn requested review from wmorgan and alpeb March 12, 2024 22:01
Copy link
Member

@wmorgan wmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, thanks. I think this whole schema thing is a huge maintenance burden with very dubious value and I would argue for making this just a regular page.

linkerd.io/content/common-errors/_index.md Outdated Show resolved Hide resolved
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to avoid having these links pointing to 2.15 staling out on each major release, I suggest moving this doc to linkerd.io/content/2.15/common-errors/_index.md, and use relative links instead. The common-errors doc will get copied then on each major release, like we do with the rest, without further changes required.

linkerd.io/layouts/partials/sidebar-2.html Outdated Show resolved Hide resolved
@kflynn
Copy link
Member Author

kflynn commented Mar 29, 2024

I moved this into a normal section, parallel to features -- better?

@kflynn kflynn requested review from alpeb and wmorgan March 29, 2024 02:03
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to remove the change in sidebar-2.html 😉

Signed-off-by: Flynn <[email protected]>
@kflynn kflynn merged commit 7d9d0d4 into main Apr 4, 2024
7 checks passed
@kflynn kflynn deleted the flynn/common-errors branch April 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants