Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checks redirect in 2.15 docs #1769

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Fix checks redirect in 2.15 docs #1769

merged 6 commits into from
Apr 26, 2024

Conversation

travisbeckham
Copy link
Collaborator

No description provided.

Signed-off-by: Travis Beckham <[email protected]>
@@ -6,7 +6,7 @@
<script type="text/javascript">
window.onload = function() {
var hash = window.location.hash;
window.location.href = window.location.origin + "/2.14/tasks/troubleshooting/" + hash;
window.location.href = window.location.origin + "/2.15/tasks/troubleshooting/" + hash;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have this be /2/tasks/troubleshooting/?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. That should be fine. I should probably update all of the old docs to do the same.

Copy link
Member

@wmorgan wmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since this is a new type of error I would advocate for adding some new language to the help doc as well. I will push a commit to the branch.

Copy link
Member

@wmorgan wmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you

@travisbeckham travisbeckham merged commit 9a9da49 into main Apr 26, 2024
7 checks passed
@travisbeckham travisbeckham deleted the travis/checks branch April 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants