-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checks redirect in 2.15 docs #1769
Conversation
Signed-off-by: Travis Beckham <[email protected]>
@@ -6,7 +6,7 @@ | |||
<script type="text/javascript"> | |||
window.onload = function() { | |||
var hash = window.location.hash; | |||
window.location.href = window.location.origin + "/2.14/tasks/troubleshooting/" + hash; | |||
window.location.href = window.location.origin + "/2.15/tasks/troubleshooting/" + hash; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have this be /2/tasks/troubleshooting/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. That should be fine. I should probably update all of the old docs to do the same.
Signed-off-by: Travis Beckham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Since this is a new type of error I would advocate for adding some new language to the help doc as well. I will push a commit to the branch.
Signed-off-by: William Morgan <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you
No description provided.