Feature ambassador #1791
Merged
Feature ambassador #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add search index (linkerd#1777)
Signed-off-by: Karina Rodriguez <[email protected]>
|
@karr9, muchas gracias! Lo único que prefiero sería que, en vez de aplicar los estilos basado en el nombre del embajador, podemos tener un attribute o algo así? Seguro que en el futuro tendrémos mas embajadores emiriti... -- @karr9, many thanks! The only thing I'd like would be if we could have a flag or some such instead of applying the styling based on the name of the ambassador. I'm sure we'll have more ambassadors emeriti in the future... |
ok, agregare un atributo nuevo y en base a ese se hará el highlight |
Signed-off-by: Karina Rodriguez <[email protected]>
|
@kflynn I have added a new property highlight: true or false, only with this is the change made to the card |
kflynn
added a commit
that referenced
this pull request
Jun 24, 2024
kflynn
pushed a commit
that referenced
this pull request
Jun 27, 2024
* styles and code are added to highlight an ambassador Signed-off-by: Karina Rodriguez <[email protected]> * A new property was added to highlight an ambassador Signed-off-by: Karina Rodriguez <[email protected]> --------- Signed-off-by: Karina Rodriguez <[email protected]> Co-authored-by: Karina Rodriguez <[email protected]> Co-authored-by: Flynn <[email protected]> (cherry picked from commit 55bc952)
kflynn
pushed a commit
that referenced
this pull request
Jun 27, 2024
* styles and code are added to highlight an ambassador Signed-off-by: Karina Rodriguez <[email protected]> * A new property was added to highlight an ambassador Signed-off-by: Karina Rodriguez <[email protected]> --------- Signed-off-by: Karina Rodriguez <[email protected]> Co-authored-by: Karina Rodriguez <[email protected]> Co-authored-by: Flynn <[email protected]> (cherry picked from commit 55bc952)
kflynn
added a commit
that referenced
this pull request
Jun 27, 2024
* styles and code are added to highlight an ambassador Signed-off-by: Karina Rodriguez <[email protected]> * A new property was added to highlight an ambassador Signed-off-by: Karina Rodriguez <[email protected]> --------- Signed-off-by: Karina Rodriguez <[email protected]> Co-authored-by: Karina Rodriguez <[email protected]> Co-authored-by: Flynn <[email protected]> (cherry picked from commit 55bc952) Co-authored-by: Karina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
styles and code are added to highlight an ambassador