Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to page.Path instead of file.Page.Path, because the latter breaks horribly for me, although apparently for no one else??? #1798

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Jul 2, 2024

It doesn't make any sense that .page.File.Path works great in production, but fails on my Mac with exactly the same version of Hugo... but it does, and the Hugo docs imply that .page.Path is the smarter way to go. So let's do that.

(And many thanks to @travisbeckham for digging into this with me!!)

Signed-off-by: Flynn [email protected]

…aks horribly for me, although apparently for no one else???

Signed-off-by: Flynn <[email protected]>
@kflynn kflynn requested a review from travisbeckham July 2, 2024 16:06
Copy link
Collaborator

@travisbeckham travisbeckham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This seems to work well.

@kflynn kflynn merged commit ff60bfd into main Jul 2, 2024
7 checks passed
@kflynn kflynn deleted the flynn/dev/build-fix branch July 2, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants