Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build package #5

Merged
merged 7 commits into from
Jan 16, 2025
Merged

feat: build package #5

merged 7 commits into from
Jan 16, 2025

Conversation

ElderMatt
Copy link
Collaborator

No description provided.

j-zimnowoda
j-zimnowoda requested changes Nov 4, 2024
View reviewed changes
bin/generate-package.sh Outdated Show resolved Hide resolved
bin/common.sh Outdated Show resolved Hide resolved
j-zimnowoda
j-zimnowoda requested changes Nov 27, 2024
View reviewed changes
Copy link

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package release should not happen on every build.
I recommend to look at build pipelines of other apl related repos.

@CasLubbers
Copy link

Package release should not happen on every build. I recommend to look at build pipelines of other apl related repos.

I've changed it so it publishes only when the build is run from main

@CasLubbers CasLubbers force-pushed the melderho-package-build branch from bcdfad1 to a1eaa39 Compare January 16, 2025 08:57
@CasLubbers CasLubbers merged commit f3f0b26 into main Jan 16, 2025
1 check passed
@CasLubbers CasLubbers deleted the melderho-package-build branch January 16, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda requested changes

@CasLubbers CasLubbers CasLubbers approved these changes

@ferruhcihan ferruhcihan Awaiting requested review from ferruhcihan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElderMatt @CasLubbers @j-zimnowoda