Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vale GHA improvements #4304

Merged
merged 4 commits into from
May 14, 2021
Merged

Vale GHA improvements #4304

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c551efc
Integrate workaround for "head commit not ahead of base commit"
nmelehan May 7, 2021
569895f
Vale GHA: filter out files that aren't inside docs/ directory
nmelehan Apr 23, 2021
a1b3bf4
Only run the Vale step if list of files in docs/ is not empty
nmelehan May 10, 2021
c5155f1
Vale GHA: add comments
nmelehan May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
- name: Get Changed Files
id: get_changed_files
uses: jitterbit/get-changed-files@v1
continue-on-error: true
Copy link
Collaborator Author

@nmelehan nmelehan May 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how c551efc was tested out:

  1. I made a new branch off of main with a new test markdown file. The file doesn't matter; what matters is that the branch was made off of main. I then made a pull request that targeted develop (not main) for this branch:

    • test vale stuff #4306
    • Our Vale GitHub action failed on this with the head commit error because main, which was used to start the new branch, is currently behind develop

  2. I made another new branch off of main with the proposed continue-on-error: true fix. Then I made a pull request that targeted develop (not main) for this branch:

with:
format: 'json'
- name: Vale
Expand Down