Skip to content

Conversation

@jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Oct 31, 2025

Description 📝

The app has been upgraded to Vite 7. Storybook v9 has compatibility issues and v10 is the supported line for Vite 7.

Storybook v10 is ESM-only and requires Node 20.19+ or 22.12+

https://storybook.js.org/docs/releases/migration-guide

Changes 🔄

  • Bump Storybook dependencies to v10:
    • storybook, @storybook/react-vite, @storybook/addon-docs, @storybook/addon-a11y in packages/manager.
    • @storybook/react-vite in packages/ui and packages/shared.
  • Validate .storybook configs (main.ts, preview.tsx, viteFinal) continue to work under v10.
  • Confirm the dark mode addon compatibility. If @vueless/storybook-dark-mode is not v10-compatible, migrate to @storybook/addon-themes.
  • Ensure Node used by Storybook is ≥ 20.19 or ≥ 22.12.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

N/A

How to test 🧪

Verification steps

  • pnpm --filter linode-manager storybook starts successfully on Node 22.19 and loads stories.
  • pnpm --filter linode-manager build-storybook completes without errors.
  • Docs tab renders (MDX+autodocs) without TS or runtime errors.
  • Dark mode toggle works in both Canvas and Docs.
  • No new ESLint/TS errors in packages/manager due to the upgrade.
  • CI passes Storybook build step.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai jaalah-akamai self-assigned this Oct 31, 2025
@jaalah-akamai jaalah-akamai requested review from a team as code owners October 31, 2025 00:01
@jaalah-akamai jaalah-akamai requested review from fabrice-akamai and removed request for a team October 31, 2025 00:01
@jaalah-akamai jaalah-akamai added the Dependencies Pull requests that update a dependency file label Oct 31, 2025
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v10 seems to be working well. Cold-starting the dev server still is a bit slow, but that's nothing new. (I think it's due to the fact tsc runs to generate the auto-doc)

Image

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing860 Passing11 Skipped39m 8s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why there's this issue with my local configuration, but I've been unable to get it running so far:

Screenshot 2025-11-17 at 2 18 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file Storybook

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

5 participants