fix: [UIE-9661] - oAuth callback improvements #13105
Open
+70
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
commented
Nov 20, 2025
| ? getQueryParamsFromQueryString(options.params) | ||
| : options.params | ||
| ) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Just added some typeguard here to satisfy the new callback strict route types
| const authenticate = async () => { | ||
| try { | ||
| const { returnTo } = await handleOAuthCallback({ | ||
| params: location.search, |
Contributor
Author
There was a problem hiding this comment.
This is one potential issue:
here we were using windows.location which means it would get evaluated (and return a value) before router initiation.
| '/admin/callback', | ||
| '/oauth/callback', | ||
| '/cancel', | ||
| ]; |
Contributor
Author
There was a problem hiding this comment.
This is the fix to not redirect to one of these routes in order to never be stuck in a logout loop
| }); | ||
|
|
||
| const hasStartedAuth = React.useRef(false); | ||
| const isAuthenticating = React.useRef(false); |
Contributor
Author
There was a problem hiding this comment.
Using references to avoid triggering the callback more than needed and end up with stale values
| profile: Profile | undefined | ||
| ): Promise<boolean> => { | ||
| if (!flags?.iam?.enabled) { | ||
| if (!flags?.iam?.enabled || !profile) { |
Contributor
Author
There was a problem hiding this comment.
not directly related to this PR. just a follow up to #13037
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/helpAndSupport/open-support-ticket.spec.ts" |
|||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR attempts to fix a couple issues with the oAuth callback.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Reproduction steps
Some of this isn't consistently reproducible, happens on various network speed and/or reasons unbeknown to us mortals.
see ticket for details:
M3-9661However, on a slow connection this can easily be reproduced:
/logoutVerification steps
👉 try all sorts of logins & logouts in various environments at various network speeds
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅