feat: [M3-7128] - Coverage Report - Part 1 #9772
Conversation
abailly-akamai
force-pushed
the
M3-7128
branch
from
a75989e to
04996a8
Compare
abailly-akamai
force-pushed
the
M3-7128
branch
2 times, most recently
from
3344459 to
3b6e039
Compare
abailly-akamai
changed the title
| @@ -53,7 +53,6 @@ | |||
| "lodash": "^4.17.21", | |||
| "glob-parent": "^5.1.2", | |||
| "hosted-git-info": "^5.0.0", | |||
| "minimatch": "^9.0.2", | |||
There was a problem hiding this comment.
We don't need a resolution here. This was part of the reason the coverage script was not running - this was last changed when I worked on the perfectionist linting job and we had a conflict. Instead of a resolution, we should allow both versions to be available.
abailly-akamai
requested review from
jdamore-linode,
jaalah-akamai,
bnussman-akamai and
coliu-akamai
and removed request for
a team
abailly-akamai
force-pushed
the
M3-7128
branch
from
8076a42 to
a4cd2f9
Compare
abailly-akamai
dismissed
bnussman-akamai’s stale review
Put back into draft cause I need to rework a couple things
abailly-akamai
force-pushed
the
M3-7128
branch
from
0da8005 to
416277e
Compare
abailly-akamai
force-pushed
the
M3-7128
branch
from
cd266e1 to
9e1ca12
Compare
abailly-akamai
force-pushed
the
M3-7128
branch
from
a9487ec to
9155fb1
Compare
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: ref_code_coverage | ||
| path: ref_code_coverage.txt |
There was a problem hiding this comment.
This will fail right now cause code coverage isn't working on develop. Once merged, coverage will start running again and this will succeed
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| message: | | ||
| $(cat updated_comment.txt) | ||
|
|
There was a problem hiding this comment.
this action won't run till merged to develop. I am expecting to iterate on it on part 2, or maybe it'll just work!
| <p align="center"> | ||
| <img alt="Linode/Manager Coverage" src="https://img.shields.io/badge/%40linode%2Fmanager_coverage-N%2FA%25-yellow" /> | ||
| </p> | ||
|
|
There was a problem hiding this comment.
we're adding a badge to our front page. This should work once merged, although i may need to add our token to the job.
packages/manager/package.json
Outdated
| "!src/**/*.hooks.{js,jsx,ts,tsx}", | ||
| "!src/**/*.stories.{js,jsx,ts,tsx}", | ||
| "!src/**/index.{js,jsx,ts,tsx}", | ||
| "!src/**/*.styles.{js,jsx,ts,tsx}" |
There was a problem hiding this comment.
we may want to iterate on those as we go. Basically we want to collect coverage from the most relevant code paths. For instance, it does not make sense to include all features in the coverage however we want to include the utilities from there.
abailly-akamai
force-pushed
the
M3-7128
branch
from
96904e6 to
f11cbc6
Compare
Description 📝
This PR is Part 1 of 2.
The way GH actions work, we need the base job ("Code Coverage") to be in the development branch for the depending job ("Coverage Comment") to trigger. The reason we have two different jobs is because of being able to comment on forked PRs and secrets are stripped from jobs triggered by forked
pull_request.I assume tuning will be needed once this is merged and it may create some noise for a couple days. No big deal, none of this will stop a PR from bring merged and will announce the changes/disturbance in our channel. No pain no gain.
Note: changeset will be added in next PR!
Second Note: Please pardon the many commits and notices, it was an experimental branch that got prematurely put in review.
Changes 🔄
on: [pull_request]Preview 📷
How to test 🧪
yarnto update your dependenciesyarn coverageAs an Author I have considered 🤔
Check all that apply