Establish new connection upon retry before marking dead #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dead, to avoid reusing a stale socket.
ricardosantosalves
force-pushed
the
master
branch
from
68be49b
to
d26c66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get and set implementations have a last retry step before marking a server as dead. The current implementation of retry is re-using the existing socket and only then marking the server dead. In case of stale sockets, for example, if the memcached server is restarted, although it's already up and running, it will still be marked as dead.
The change in this PR makes sure that a new connection is established upon retry, to avoid reusing a stale socket, before marking it as dead.