Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

add NME_SC method for clustering #1

Open
wants to merge 12 commits into
base: max_speaker
Choose a base branch
from
Open

add NME_SC method for clustering #1

wants to merge 12 commits into from

Conversation

wghezaiel
Copy link
Member

add auto-tuning NME_spectral clustering

Copy link
Member

@Jeronymous Jeronymous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments after a first quick reading here.

I noticed that the function cluster_AHC does not have any option max_speakers.
Is it normal? Would it make sense to add such an option there?

simple_diarizer/cluster.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
def NME_SpectralClustering(
A, num_clusters=None, max_num_clusters=10, pbest=0, pmin=3, pmax=20
):
print(num_clusters,max_num_clusters)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No print without any string to explain.
This one looks like a debug print. remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

simple_diarizer/cluster.py Outdated Show resolved Hide resolved
simple_diarizer/cluster.py Outdated Show resolved Hide resolved
simple_diarizer/diarizer.py Outdated Show resolved Hide resolved
simple_diarizer/diarizer.py Outdated Show resolved Hide resolved
simple_diarizer/diarizer.py Outdated Show resolved Hide resolved
simple_diarizer/diarizer.py Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants