RFE: add file_permission test #110
Conversation
pcmoore
changed the title
rprobaina
force-pushed
the
file-permission-event-filtering-test
branch
2 times, most recently
from
1e4e2c7
to
a3fa91d
Compare
|
Hi @pcmoore, First of all, thanks for being willing to review this PR. I noticed that the CI syntax check failed and I just submitted a new version with the syntax format fixed. This is my first contribution to audit-testsuite project. So, please let me know if there's anything I could do better next time. Best regards, |
|
Hi @rprobaina, thank you very much for the PR! I've got a couple of quick review comments but first I just wanted to say how much the additional test is appreciated :) |
Add a very basic file permission change event filtering tests using the perl Test::Simple framework and with the file_delete test as inspiration. See: linux-audit#12 Signed-off-by: Ricardo Robaina <[email protected]>
rprobaina
force-pushed
the
file-permission-event-filtering-test
branch
from
a3fa91d
to
43ab425
Compare
Hi @pcmoore, thanks for reviewing it! I've just pushed a new version containing the changes requested. |
|
Hi @pcmoore, I pushed the reviewed version of this PR a few months ago, did have a chance to check it? Please, let me know if there's anything else I should do. --Ricardo |
|
Merged via 9d2ddc2, thanks @rprobaina! |
Add a very basic file permission change event filtering tests using the perl Test::Simple framework and with the file_delete test as inspiration.
See: #12
Signed-off-by: Ricardo Robaina [email protected]