Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J1939 vehicle position #553

Merged
merged 3 commits into from
Mar 2, 2025

Conversation

olerem
Copy link
Contributor

@olerem olerem commented Aug 4, 2024

This patch set provide support for the GPSD to J1939 service. I managed to make CmakeList work so far, but i still need help to make Makefile work properly too. How to manage properly gpsd dependecy, currenty i do not know.

@olerem olerem requested review from marckleinebudde and hartkopp and removed request for marckleinebudde August 4, 2024 13:27
@olerem
Copy link
Contributor Author

olerem commented Aug 4, 2024

To make it compile libgps-dev package is required.

@marckleinebudde
Copy link
Member

To make it compile libgps-dev package is required.

We need a cmake option for this.

@marckleinebudde
Copy link
Member

@marckleinebudde
Copy link
Member

marckleinebudde commented Aug 5, 2024

Have a look at https://github.com/marckleinebudde/can-utils/tree/j1939_vehicle_position for a WIP github actions fix.

@olerem olerem force-pushed the j1939_vehicle_position branch 2 times, most recently from d61e849 to 4fe8337 Compare December 29, 2024 10:51
@olerem olerem force-pushed the j1939_vehicle_position branch from 4fe8337 to 2638b39 Compare December 29, 2024 11:03
@olerem
Copy link
Contributor Author

olerem commented Jan 31, 2025

Hi all, how to proceed with this pull request?

@yegorich
Copy link
Contributor

yegorich commented Mar 1, 2025

Could add someething like in this patch to enable and detect GPS feature.
gps.patch

Introduce `libj1939_connect_socket` function to handle socket
connections.

Signed-off-by: Oleksij Rempel <[email protected]>
@marckleinebudde marckleinebudde force-pushed the j1939_vehicle_position branch from 2638b39 to 3fabeb6 Compare March 1, 2025 13:07
@marckleinebudde
Copy link
Member

marckleinebudde commented Mar 1, 2025

Could add someething like in this patch to enable and detect GPS feature. gps.patch

Seems to work now. Thanks @yegorich.

Debian builds native, cross to armhf and arm64 with libgps and mips without libgps. Trying to get Ubuntu happy now.

@yegorich
Copy link
Contributor

yegorich commented Mar 1, 2025

Looks like it was a temporary problem.

@marckleinebudde
Copy link
Member

No, armhf and arm64 live in a different URL...still working on it.

olerem and others added 2 commits March 1, 2025 22:29
…ition Server

This patch adds `j1939-vehicle-position-srv`, a server for sending
vehicle position data over CAN using J1939 or NMEA 2000 protocols. It
retrieves GPS data from gpsd or simulates data if gpsd is unavailable.
By default, it operates in J1939 profile but can switch to NMEA 2000
with the `-p nmea2000` option.

Usage Examples:
1. With gpsd:
   j1939acd -r 64-95 -c /tmp/1122334455667789.jacd 1122334455667789 vcan0 &
   j1939-vehicle-position-srv -i vcan0 -n 0x1122334455667789

2. In simulation mode without gpsd:
   j1939-vehicle-position-srv -i vcan0 -s -p nmea2000

Signed-off-by: Oleksij Rempel <[email protected]>
[Yegor: add CMakeLists.txt integration]
Co-developed-by: Yegor Yefremov <[email protected]>
@marckleinebudde marckleinebudde force-pushed the j1939_vehicle_position branch from 3fabeb6 to e448d54 Compare March 1, 2025 21:30
@marckleinebudde
Copy link
Member

marckleinebudde commented Mar 1, 2025

The packages for Debian unstable and experimental are not available in the same version for all archs right now. This is a temporary failure. But it's working on rolling Ubuntu and Debian testing. 🎉

@yegorich
Copy link
Contributor

yegorich commented Mar 1, 2025

Yes, there are two Multiarch issues: https://tracker.debian.org/pkg/glibc

@marckleinebudde
Copy link
Member

Thanks for looking that up. Merge anyways?

@yegorich
Copy link
Contributor

yegorich commented Mar 1, 2025

I'd say, yes.

@marckleinebudde marckleinebudde merged commit 18b1e79 into linux-can:master Mar 2, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants