Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SM8650 debugcc entries #25

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add SM8650 debugcc entries #25

merged 1 commit into from
Nov 7, 2023

Conversation

superna9999
Copy link
Member

This adds Debugcc support for SM8650

MarijnS95
MarijnS95 reviewed Oct 25, 2023
View reviewed changes
sm8650.c Outdated Show resolved Hide resolved
MarijnS95
MarijnS95 reviewed Oct 25, 2023
View reviewed changes
sm8650.c Outdated Show resolved Hide resolved
MarijnS95
MarijnS95 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM (haven't checked any of the values) though perhaps we should land #24 and #26 first to make this even cleaner?

sm8650.c Outdated Show resolved Hide resolved
sm8650.c Outdated Show resolved Hide resolved
@superna9999
Copy link
Member Author

@MarijnS95 sure, I'll rebase when both are merged

@superna9999 superna9999 marked this pull request as draft November 7, 2023 09:07
@superna9999 superna9999 marked this pull request as ready for review November 7, 2023 11:46
lumag
lumag requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, few minor nits.

sm8650.c Outdated Show resolved Hide resolved
sm8650.c Outdated Show resolved Hide resolved
sm8650.c Show resolved Hide resolved
@superna9999
Add SM8650 debugcc entries
3f8e838 
Add debugcc tables for the SM8650 platform

Signed-off-by: Neil Armstrong <[email protected]>
@lumag lumag merged commit e68ff01 into linux-msm:master Nov 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumag lumag lumag approved these changes

@MarijnS95 MarijnS95 Awaiting requested review from MarijnS95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@superna9999 @lumag @MarijnS95