meson: Use configuration_data() instead of piping variables through echo
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Baryshkov <[email protected]>
|
I think |
MarijnS95
force-pushed
the
meson-config-data
branch
from
95347f1
to
8c3d888
Compare
Testing whether the CI could catch that 😏 |
MarijnS95
force-pushed
the
meson-config-data
branch
from
8c3d888
to
98ed886
Compare
lumag
requested changes
Nov 6, 2023
platforms.c.in
Outdated
|
|
||
| @PLATFORM_DEFS@ | ||
| const struct debugcc_platform *platforms[] = { | ||
| @PLATFORM_ARRAY@ NULL, |
There was a problem hiding this comment.
Could you please add a newline before NULL?
There was a problem hiding this comment.
Was just trying out whether to use '\n'.join() which intersperses (first push), then switched to += '...\n' which places it at the last entry and needs such hacks (see also no empty line between @PLATFORM_DEFS@ and const struct ...).
Not that it really matters, no-one should care about reading build/platform.c.in so we could have an empty line too-many either way.
… `echo` Having a template file with replacement macros is a bit cleaner than encoding the setup of the file in `meson.build` and piping that through `echo` with caputred variables. Unfortunately there appears to be no support for repetition, to e.g. expand a list of platform names into the various uses (array with comma- separation, or individual `extern struct` declarations, forcing us to have some form of string expansion within `meson.build`).
MarijnS95
force-pushed
the
meson-config-data
branch
from
98ed886
to
4d332b2
Compare
lumag
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a template file with replacement macros is a bit cleaner than encoding the setup of the file in
meson.buildand piping that throughechowith caputred variables.Unfortunately there appears to be no support for repetition, to e.g. expand a list of platform names into the various uses (array with comma-separation, or individual
extern structdeclarations, forcing us to have some form of string expansion withinmeson.build).