Skip to content

Commit

Permalink
nvme-fabrics: enable option 'concat'
Browse files Browse the repository at this point in the history
Enable the option 'concat' to start secure concatenation on TCP
connections.

Signed-off-by: Hannes Reinecke <[email protected]>
  • Loading branch information
hreinecke authored and igaw committed Jan 23, 2024
1 parent f30a1ec commit 6cbe764
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
5 changes: 4 additions & 1 deletion Documentation/nvme-connect-all.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ SYNOPSIS
[--nr-poll-queues=<#> | -P <#>]
[--queue-size=<#> | -Q <#>] [--keyring=<#>]
[--tls_key=<#>] [--hdr-digest | -g] [--data-digest | -G]
[--persistent | -p] [--tls] [--quiet | -S]
[--persistent | -p] [--tls] [--concat] [--quiet | -S]
[--dump-config | -O] [--nbft] [--no-nbft]
[--nbft-path=<STR>] [--context=<STR>]
[--output-format=<fmt> | -o <fmt>] [--verbose | -v]
Expand Down Expand Up @@ -186,6 +186,9 @@ OPTIONS
--tls::
Enable TLS encryption (TCP).

--concat::
Enable secure concatenation (TCP).

-S::
--quiet::
Suppress error messages.
Expand Down
5 changes: 4 additions & 1 deletion Documentation/nvme-connect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ SYNOPSIS
[--keyring=<#>] [--tls_key=<#>]
[--duplicate-connect | -D] [--disable-sqflow | -d]
[--hdr-digest | -g] [--data-digest | -G] [--tls]
[--dump-config | -O] [--application=<id>]
[--concat] [--dump-config | -O] [--application=<id>]
[--output-format=<fmt> | -o <fmt>] [--verbose | -v]

DESCRIPTION
Expand Down Expand Up @@ -176,6 +176,9 @@ OPTIONS
--tls::
Enable TLS encryption (TCP).

--concat::
Enable secure concatenation (TCP).

-O::
--dump-config::
Print out resulting JSON configuration file to stdout.
Expand Down
5 changes: 4 additions & 1 deletion Documentation/nvme-discover.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ SYNOPSIS
[--nr-poll-queues=<#> | -P <#>]
[--queue-size=<#> | -Q <#>] [--keyring=<#>]
[--tls_key=<#>] [--hdr-digest | -g] [--data-digest | -G]
[--persistent | -p] [--quiet | -S] [--tls]
[--persistent | -p] [--quiet | -S] [--tls] [--concat]
[--dump-config | -O] [--output-format=<fmt> | -o <fmt>]
[--force] [--nbft] [--no-nbft] [--nbft-path=<STR>]
[--context=<STR>]
Expand Down Expand Up @@ -206,6 +206,9 @@ OPTIONS
--tls::
Enable TLS encryption (TCP).

--concat::
Enable secure concatenation (TCP).

-S::
--quiet::
Suppress already connected errors.
Expand Down
2 changes: 2 additions & 0 deletions fabrics.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ static const char *nvmf_disable_sqflow = "disable controller sq flow control (de
static const char *nvmf_hdr_digest = "enable transport protocol header digest (TCP transport)";
static const char *nvmf_data_digest = "enable transport protocol data digest (TCP transport)";
static const char *nvmf_tls = "enable TLS";
static const char *nvmf_concat = "enable secure concatenation";
static const char *nvmf_config_file = "Use specified JSON configuration file or 'none' to disable";
static const char *nvmf_context = "execution context identification string";

Expand Down Expand Up @@ -113,6 +114,7 @@ static const char *nvmf_context = "execution context identification string";
OPT_FLAG("hdr-digest", 'g', &c.hdr_digest, nvmf_hdr_digest), \
OPT_FLAG("data-digest", 'G', &c.data_digest, nvmf_data_digest), \
OPT_FLAG("tls", 0, &c.tls, nvmf_tls), \
OPT_FLAG("concat", 0, &c.concat, nvmf_concat), \
__VA_ARGS__, \
OPT_END() \
}
Expand Down

0 comments on commit 6cbe764

Please sign in to comment.