completions: added Solidigm plugin to autocomplete script #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amashiana-sd
force-pushed
the
solidigm_autocomplete
branch
from
f8809c9
to
cc95974
Compare
|
Could you also update the zsh completion as well? Thanks! |
Am I correct in my understanding that zsh completion is the file called _nvme? I see individual commands in there but nothing related to plugins. Do I just need to make sure all commands under Solidigm plugin are in that file? |
|
Yes, the In the long run I'd like to see zsh also implementing support for the all the plugins, that's why I ask for it :) Thanks! |
amashiana-sd
force-pushed
the
solidigm_autocomplete
branch
2 times, most recently
from
f3e6b69
to
d5b32d8
Compare
Updated both bash and zsh autocomplete scripts Fixed copy-paste error under ocp section of zsh script Signed-off-by: Anant Mashiana <[email protected]>
amashiana-sd
force-pushed
the
solidigm_autocomplete
branch
from
d5b32d8
to
8b6fa05
Compare
|
Very cool. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.