plugins/wdc: Fix code scanning alert #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for the issue #2204. |
igaw
reviewed
Feb 11, 2024
| __u32 chunckSize = WDC_DE_VU_READ_BUFFER_STANDARD_OFFSET; | ||
| __u32 maximumTransferLength = 0; | ||
| __u32 buffSize = 0; | ||
| __u64 offsetIdx = 0; |
There was a problem hiding this comment.
Please do not mix whitespace changes with code changes.
There was a problem hiding this comment.
Sorry for mixing the changes everytime so just split the changes to commits.
ikegami-t
force-pushed
the
wdc-code-scan
branch
from
474f67f
to
8d6ea5b
Compare
|
Please use a more fitting commit title. |
ikegami-t
force-pushed
the
wdc-code-scan
branch
from
8d6ea5b
to
cd21a61
Compare
Delete the loop variable since not changed the value. Also delete the some variables initial values not necessary. Signed-off-by: Tokunori Ikegami <[email protected]>
Fix the comparison of narrow type with wide type in loop condition. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
wdc-code-scan
branch
from
cd21a61
to
fc584a5
Compare
|
Sorry for too late to do this and just fixed the commit subject as below. - plugins/wdc: Change for loop index variable type to __u32
+ plugins/wdc: Fix narrow index variable type in for loop to __u32 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the comparison of narrow type with wide type in loop condition.
Note: Include some coding style errors fixes.