White space changes #2216
White space changes #2216
Conversation
ikegami-t
force-pushed
the
white-space
branch
from
24ef58b
to
27fd26d
Compare
|
Todo: Change register value output to use the macros |
ikegami-t
force-pushed
the
white-space
branch
from
7fc48ad
to
8b202a6
Compare
Documentation/nvme-set-property.txt
Outdated
| --offset:: | ||
| The offset of the property. | ||
|
|
||
| -V:: | ||
| --value: | ||
| -V <val>:: | ||
| --value=<val>:: |
There was a problem hiding this comment.
This is inconsistent with --offset, which also takes a value. I see other command arguments that take arguments not having them specified here (e.g. nvme get-property --offset). Why only change this one?
There was a problem hiding this comment.
Missed it so just fixed.
nvme-print-stdout.c
Outdated
| @@ -3264,20 +3278,21 @@ static void stdout_zns_changed(struct nvme_zns_changed_zone_log *log) | |||
|
|
|||
| static void stdout_zns_report_zone_attributes(__u8 za, __u8 zai) | |||
| { | |||
| const char *const recommended_limit[4] = {"","1","2","3"}; | |||
| const char *const recommended_limit[4] = {"", "1", "2", "3"}; | |||
There was a problem hiding this comment.
Add a space between * and const while you're touching this line? const char * const
ikegami-t
force-pushed
the
white-space
branch
2 times, most recently
from
6c1db3a
to
e1843b8
Compare
nvme-print-stdout.c
Outdated
| chan_desc = (struct nvme_end_grp_chan_desc *) \ | ||
| ((cap->cap_config_desc[i].egcd[j].nvmsetid[0]) * (sizeof(__u16)*egsets)); | ||
| chan_desc = (struct nvme_end_grp_chan_desc *) | ||
| (sizeof(__u16) * egsets * cap->cap_config_desc[i].egcd[j].nvmsetid[0]); |
There was a problem hiding this comment.
This part should be in the next patch. It's not a white space change thus it should get a proper commit message with it.
| sscanf(nvme_ns_get_name(n), "nvme%dn%d", &instance, &head_instance); | ||
| if (sscanf(nvme_ns_get_name(n), "nvme%dn%d", &instance, &head_instance) != 2) | ||
| return; | ||
|
|
There was a problem hiding this comment.
Not a whitespace change. Should be in a different patch.
| le16_to_cpu(cap->cap_config_desc[i].egcd[j].nvmsetid[k])); | ||
| } | ||
| le16_to_cpu(cap->cap_config_desc[i].egcd[j].nvmsetid[k])); | ||
|
|
There was a problem hiding this comment.
Split whitespace change and logical changes into separate patches.
| -O:: | ||
| --offset:: | ||
| -O <offset>:: | ||
| --offset=<offset>:: |
There was a problem hiding this comment.
Just split the two different changes into two patches. One which fixes the mode settings and one which fixes the offset changes. Thanks.
|
A few nitpicks. Could you rebase the series to the latest upstream version when you updating the series? There is merge conflict in nvme-print.c Thanks. |
Fix to change space characters for indentation to tab characters. Delete a space between cast parentheses and variable. Signed-off-by: Tokunori Ikegami <[email protected]>
Fix for the checkpatch.pl error. Signed-off-by: Tokunori Ikegami <[email protected]>
All the cases listed adjacently and use only for cases have any body. Signed-off-by: Tokunori Ikegami <[email protected]>
Note: The long line string and strncpy() warnings are not fixed. Signed-off-by: Tokunori Ikegami <[email protected]>
To fix linux kernel check patch error. Signed-off-by: Tokunori Ikegami <[email protected]>
Set the address after NVM set EGSETS - 1 identifier parameter. Signed-off-by: Tokunori Ikegami <[email protected]>
Only the get-property and set-property commands fixed errors. Signed-off-by: Tokunori Ikegami <[email protected]>
Those parameters need the <offset> and <val> parameters values. Signed-off-by: Tokunori Ikegami <[email protected]>
|
Thanks. |
Includes some minor changes also. Just split the chagnes from the PR #2188 but deleted the long line string changes.