rpm: Add missing rule and service files #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmi-jeon
force-pushed
the
add-rules-service
branch
7 times, most recently
from
eb4706e
to
2d24091
Compare
|
Hi @igaw WARNING: Non-standard signature: Co-authored-by: |
Rule and service were added previously. But rule and service files were not added the spec file. So add missing rule and service files. make rpm result: Installed (but unpackaged) file(s) found: /usr/local/lib/systemd/system/nvmf-connect-nbft.service /usr/local/lib/udev/rules.d/65-persistent-net-nbft.rules Signed-off-by: Minsik Jeon <[email protected]> Co-authored-by: Ra See <[email protected]>
|
It seems to be unhappy with the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule and service were added previously.
096c3e6
5ea373e
But rule and service files were not added the spec file. So add missing rule and service files.
make rpm result:
Installed (but unpackaged) file(s) found:
/usr/local/lib/systemd/system/nvmf-connect-nbft.service
/usr/local/lib/udev/rules.d/65-persistent-net-nbft.rules