Ocp wo json #2503
Open
Ocp wo json #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was wondering if we should move the json code into a separate files and only include them when the json library is available, like we have with |
|
Okay will try to do it. Thank you. |
ikegami-t
force-pushed
the
ocp-wo-json
branch
from
cbe3ac5
to
a0c0cdf
Compare
At first only hwcomp print code moved. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
ocp-wo-json
branch
from
a0c0cdf
to
b76ae83
Compare
igaw
reviewed
Sep 20, 2024
plugins/ocp/meson.build
Outdated
| @@ -6,5 +6,9 @@ sources += [ | |||
| 'plugins/ocp/ocp-fw-activation-history.c', | |||
| 'plugins/ocp/ocp-telemetry-decode.c', | |||
| 'plugins/ocp/ocp-hardware-component-log.c', | |||
| 'plugins/ocp/ocp-print.c', | |||
| 'plugins/ocp/ocp-print-stdout.c', | |||
| 'plugins/ocp/ocp-print-json.c', | |||
There was a problem hiding this comment.
The json file should only be added when the json library is available. And then you could update the plugins/meson.build file to always build the ocp plugin.
The rest looks good!
There was a problem hiding this comment.
Update the meson.build files by the additional commit. Thank you.
Note: Still some exisitng ocp commands files needed to split json code.
Still ocp-nvme.c and some other ocp commands files depended on json. Signed-off-by: Tokunori Ikegami <[email protected]>
Moved into print stdout and json files. Signed-off-by: Tokunori Ikegami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.