mlx5: Fix byte_count type in umr_sg_list_create #1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change byte_count variable from int to uint64_t to match the reglen parameter type and prevent potential overflow issues when working with large memory registrations in UMR (User-Mode Memory Registration) operations. The function signature uses uint64_t *reglen, but byte_count was declared as int, which could cause type mismatch issues and potential overflow when accumulating large transfer sizes across multiple SGEs. Signed-off-by: Dennis van der Staay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change byte_count variable from int to uint64_t to match the reglen parameter type and prevent potential overflow issues when working with large memory registrations in UMR (User-Mode Memory Registration) operations.
The function signature uses uint64_t *reglen, but byte_count was declared as int, which could cause type mismatch issues and potential overflow when accumulating large transfer sizes across multiple SGEs.