Skip to content

fix: Fix fail to install in deepin os version - #427

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wangrong1069:pr1201
Dec 1, 2025
Merged

deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wangrong1069:pr1201

Conversation

@wangrong1069

Copy link
Copy Markdown
Contributor

Remove the specific packages from the runtime dependencies and add them to the recommended dependencies.

Log: Fix fail to install in deepin os version
Bug: https://pms.uniontech.com/bug-view-342579.html

Remove the specific packages from the runtime dependencies and add them
to the recommended dependencies.

Log: Fix fail to install in deepin os version
Bug: https://pms.uniontech.com/bug-view-342579.html
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

我来帮你分析这个 Debian 包控制文件的变更:

  1. 语法逻辑分析:
  • 语法格式正确,符合 Debian 控制文件规范
  • 依赖项的修改符合 Debian 包管理规则
  1. 代码质量改进建议:
  • 将 deepin-license-activator 从 Depends 移至 Recommends 是合理的改进,因为许可证激活器不应该作为强制依赖项
  • 保持了其他必要依赖项不变,如 lshw、dmidecode、udisks2、hwinfo 等系统工具
  • Description 部分保持不变,描述清晰准确
  1. 性能影响分析:
  • 这个变更对性能没有直接影响
  • 将 deepin-license-activator 改为推荐依赖可以减少强制安装的组件数量,可能会略微减少系统资源占用
  1. 安全性考虑:
  • 将 deepin-license-activator 从强制依赖改为推荐依赖是更安全的选择,因为:
    • 减少了系统的强制依赖项
    • 用户可以选择是否安装许可证激活器
    • 降低了因许可证激活器潜在问题影响系统稳定性的风险
  1. 其他建议:
  • 建议在包的 changelog 中记录这个变更,说明修改原因
  • 可以考虑添加版本号约束,如果 deepin-license-activator 有特定版本要求
  • Description 中的 "Log Viewer" 建议保持统一的空格格式(目前是"Log Viewer"和"Log viewer"混用)

总体来说,这是一个合理的变更,提高了包的灵活性和安全性。建议继续保持这种做法,将非核心功能组件放在 Recommends 而不是 Depends 中。

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069

Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot
deepin-bot Bot merged commit 692f0bf into linuxdeepin:master Dec 1, 2025
17 checks passed
@wangrong1069
wangrong1069 deleted the pr1201 branch December 1, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants