-
Notifications
You must be signed in to change notification settings - Fork 9
feat: security yaml generation #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive security YAML file generation feature that allows users to create standardized security specification files for their projects. The feature provides three different template types (Basic, Comprehensive, and Child Repository) with step-by-step guided forms to collect project security information.
Key Changes
- Added YAML generation feature with three template types and multi-step form interface
- Integrated js-yaml library for YAML file generation and parsing
- Enhanced existing UI components with new functionality (tabindex support, height prop for modals, neutral tag style)
Reviewed Changes
Copilot reviewed 54 out of 57 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
frontend/package.json | Added js-yaml dependency and its TypeScript definitions |
frontend/app/components/modules/project/views/security.vue | Added "Generate YAML file" button and modal integration |
frontend/app/components/modules/project/services/security.service.ts | Added hasSecurityMdFile method and removed deprecated function |
frontend/app/components/modules/project/services/js-yaml.ts | Created YAML generation service using js-yaml library |
frontend/app/components/modules/project/config/yaml-generation/ | Implemented comprehensive YAML generation configuration system with three template types |
frontend/app/components/modules/project/components/security/yaml/ | Created modal components for YAML generation workflow |
frontend/app/components/uikit/ | Enhanced existing UI components with new props and styling |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...p/components/modules/project/config/yaml-generation/basic/yaml-basic-repository-security.vue
Outdated
Show resolved
Hide resolved
...roject/config/yaml-generation/comprehensive/yaml-comprehensive-repository-security-tools.vue
Outdated
Show resolved
Hide resolved
frontend/app/components/modules/project/components/security/yaml/generate-yaml-modal.vue
Show resolved
Hide resolved
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix and the UI bug I mentioned on chat
frontend/app/components/modules/project/components/security/yaml/generate-yaml-modal.vue
Show resolved
Hide resolved
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
No description provided.