Enable the PHP opcache and disable revalidation #149
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
|
This has been working well for me. Nice improvement! |
|
I am a bot, here are the test results for this PR:
|
Description:
I noticed that the PHP opcache is not installed or enabled. The opcache takes compiled PHP files and stores them in memory, improving performance and reducing disk IO at a small memory cost. Even in development it's a good practice to have the opcache enabled.
Since we are running in docker, there is also no point in checking files with stat calls on each request to see if they have changed. Instead, users should generally pull or rebuild the image.
Benefits of this PR and context:
I noticed this on my server because surprisingly php-fpm had the biggest IO reads out of all processes. This is because I have an uptime app checking Heimdall every 60 seconds, causing the entire Laravel app to be re-read and compiled.
How Has This Been Tested?
I changed my local to build off of this PR instead of pulling the upstream image. As well, I confirmed the opcache was enabled by dropping a phpinfo.php file in the app and verifying that the opcache extension was showing hits.
I have only tested on amd64, and not ARM.