Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, handling the
VSCODE_EXTENSION_IDS
environment variable does not allow for spaces in the string. This change strips all spaces from that variable before it is used to install extensions.The
VSCODE_EXTENSION_IDS
handling will be more flexible to allow spaces and thus allowVSCODE_EXTENSION_IDS
declarations like the following in Docker compose file:or nicer mult-line strings when one has numerous extensions.
Benefits of this PR and context:
This allows the user to include spaces in the
VSCODE_EXTENSION_IDS
value, which can improve readability in Docker compose files.How Has This Been Tested?
I replaced the existing
/etc/s6-overlay/s6-rc.d/init-mod-code-server-extension-arguments/run
file with my updated version.I ran
docker compose up
with each of the followingVSCODE_EXTENSION_IDS
definitions in the compose file. I then looked at the logging to check that the extension IDs were processed as desired.Source / References:
N/A