Remove updatenotification #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: Eric Nemchik <[email protected]>
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
aptalca
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this app does is place a notification in the admin status page telling the user to click a button to run the web updater. We don't want this. Users should instead update the container image.
I tested the logic on my own instance. No issues. It runs completely silent if the apps don't exist.
Ref:
https://github.com/nextcloud/all-in-one/blob/1771a72c0e5a37d43356c4d3e6c657dc5d4a0990/Containers/nextcloud/entrypoint.sh#L186-L192
https://github.com/nextcloud/all-in-one/blob/1771a72c0e5a37d43356c4d3e6c657dc5d4a0990/Containers/nextcloud/entrypoint.sh#L286-L287
Also added to #352